Fix fakefront S3 compatibility for moto [RHELDST-44306] - #769
Merged
crungehottman merged 1 commit intoAug 21, 2026
Merged
Conversation
Two changes to fakefront's S3 session for compatibility with spec-compliant S3 implementations (e.g. moto): 1. Sign requests with AWS SigV4. Per the S3 API spec, response override query parameters (e.g. response-content-type) require authenticated requests; unsigned requests return 403. This adds SigV4 signing using the same credentials already configured via environment variables. 2. Stream S3 response bytes without transparent decompression. The requests library auto-decompresses Content-Encoding: gzip bodies via urllib3, but fakefront passes the original S3 headers (including Content-Encoding: gzip) through to the client unchanged. This mismatch causes ContentDecodingError on the client side. Using raw.stream(decode_content=False) preserves the original bytes, keeping headers and body consistent. Both changes are backwards-compatible with LocalStack, which accepts signed requests and does not set Content-Encoding: gzip.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #769 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 340 340
=========================================
Hits 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
negillett
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to fakefront's S3 session for compatibility with spec-compliant S3 implementations (e.g. moto):
Sign requests with AWS SigV4. Per the S3 API spec, response override query parameters (e.g. response-content-type) require authenticated requests; unsigned requests return 403. This adds SigV4 signing using the same credentials already configured via environment variables.
Stream S3 response bytes without transparent decompression. The requests library auto-decompresses Content-Encoding: gzip bodies via urllib3, but fakefront passes the original S3 headers (including Content-Encoding: gzip) through to the client unchanged. This mismatch causes ContentDecodingError on the client side. Using raw.stream(decode_content=False) preserves the original bytes, keeping headers and body consistent.
Both changes are backwards-compatible with LocalStack, which accepts signed requests and does not set Content-Encoding: gzip.